[Webkit-unassigned] [Bug 77612] Stop calling Element::ensureShadowRoot in Internals.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 2 21:17:17 PST 2012


MORITA Hajime <morrita at google.com> changed:

           What    |Removed                     |Added
 Attachment #125251|review?                     |review+
               Flag|                            |

--- Comment #6 from MORITA Hajime <morrita at google.com>  2012-02-02 21:17:17 PST ---
(From update of attachment 125251)
View in context: https://bugs.webkit.org/attachment.cgi?id=125251&action=review

> Source/WebCore/ChangeLog:8
> +        Instead of ensureShadowRoot, we check the existence of shadow root and create one if there is not.

Could you explain why we need this change?

> Source/WebCore/testing/Internals.cpp:199
> +    return ShadowRoot::create(host, ec).get();

This is actually safe. But its safety isn't obvious at a glance. 
Could you change the return type to RefPtr, to make this clearly safe?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list