[Webkit-unassigned] [Bug 75930] Reimplement DETAILS and SUMMARY using selector query.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 2 21:12:56 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=75930
MORITA Hajime <morrita at google.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125250|review? |review-
Flag| |
--- Comment #2 from MORITA Hajime <morrita at google.com> 2012-02-02 21:12:56 PST ---
(From update of attachment 125250)
View in context: https://bugs.webkit.org/attachment.cgi?id=125250&action=review
Looks almost fine. Let us pick some nits.
> Source/WebCore/ChangeLog:9
> + We don't need to recreate DOM even if SUMMARY is removed or added from/into DETAILS.
"removed from added into"
> Source/WebCore/html/HTMLDetailsElement.cpp:83
> + ExceptionCode ec = 0;
Could you use ASSERT_NO_EXCEPTION here?
> Source/WebCore/html/HTMLDetailsElement.cpp:127
> ExceptionCode ec = 0;
Could you get rid of |ec| using ASSERT_NO_EXCEPTION?
> Source/WebCore/html/HTMLDetailsElement.cpp:139
> + m_mainSummary = findMainSummaryFor(this);
It looks we are now able to get rid of m_mainSummary at all. Could you investigate it?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list