[Webkit-unassigned] [Bug 77295] V8 idl code generator doesn't handle [CachedAttribute] on SerializedScriptValue attributes.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 2 16:38:26 PST 2012


Kentaro Hara <haraken at chromium.org> changed:

           What    |Removed                     |Added
 Attachment #124611|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |

--- Comment #15 from Kentaro Hara <haraken at chromium.org>  2012-02-02 16:38:26 PST ---
(From update of attachment 124611)
View in context: https://bugs.webkit.org/attachment.cgi?id=124611&action=review

Feel free to ping me if I am missing a review.

>>> Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:88
>>> +    info.Holder()->DeleteHiddenValue(v8::String::NewSymbol("cachedValue")); // Invalidate the cached value.
>> Why don't you set the new value by SetHiddenValue(), instead of invalidating the current value?
> We'd need to deserialize it, i figured it would be better to do that lazily when it's requested (i think the JSC generator does it like this as well). Also, (using this case as an example) we'd need to assume that v == imp->getCachedValue(), otherwise we'd need to call imp->getCachedValue() before deserializing, and by that point we might as well just let the getter do its job.

Makes sense!

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list