[Webkit-unassigned] [Bug 77148] [Qt][Texmap] Refactor TextureMapper API to use ImageBuffers when possible.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77148





--- Comment #29 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-02-02 10:46:23 PST ---
(In reply to comment #28)
> (In reply to comment #27)
> > (From update of attachment 124715 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=124715&action=review
> > 
> > Just a couple questions before I finish the review. Looks nice! I'm glad that we can share the ImageBuffer code with you.
> > 
> > > Source/WebCore/platform/graphics/GraphicsContext.h:413
> > > +#if ENABLE(3D_RENDERING)
> > 
> > You might want to have this be ENABLE(3D_RENDERING) && USE(TEXTURE_MAPPER). Then you could move the empty implementation out of Source/WebCore/platform/graphics/GraphicsContext.cpp.

OK, I don't mind - I just thought that concat3DTransform is not inherently specific to TextureMapper, it's just used by TextureMapper.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.