[Webkit-unassigned] [Bug 77308] [EFL] Enable WebGL with glx backend

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 2 08:02:55 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=77308


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124747|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #14 from Martin Robinson <mrobinson at webkit.org>  2012-02-02 08:02:54 PST ---
(From update of attachment 124747)
View in context: https://bugs.webkit.org/attachment.cgi?id=124747&action=review

Just a couple tiny style nits. Please fix them before landing the patch.

> Source/WebCore/platform/graphics/efl/DrawingBufferEfl.cpp:40
> +DrawingBuffer::DrawingBuffer(GraphicsContext3D* context,
> +                             const IntSize& size,
> +                             bool multisampleExtensionSupported,
> +                             bool packedDepthStencilExtensionSupported,
> +                             bool separateBackingTexture)

In WebKit we usually keep parameter lists on one line.

> Source/WebCore/platform/graphics/efl/DrawingBufferEfl.cpp:66
> +    // create a texture to render into

This comment should start with a capital letter and end with a period.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list