[Webkit-unassigned] [Bug 77520] [WK2] Modify parameters of willSubmitForm callback

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77520





--- Comment #6 from Grzegorz <g.czajkowski at samsung.com>  2012-02-02 04:35:12 PST ---
(In reply to comment #3)
> (From update of attachment 124902 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124902&action=review
> 
> This patch doesn't have any tests.

I suppose that you meant unit tests. Is there any mechanism for test WK2 API?

> 
> > Source/WebCore/loader/FormState.cpp:40
> > +static String currentValueKey = "currentValue";
> 
> This creates a static initializer and will break the AppleMac build.

Fixed - removed static and moved initialization to function.

> 
> > Source/WebCore/loader/FormState.cpp:55
> > +const Vector<HashMap<String, String> > FormState::textFieldsPropertis() const
> 
> Why are you returning const here?  textFieldsPropertis is misspelled.

Yes, you're right it is useless here. I removed it. 
Fixed typo.

> 
> > Source/WebCore/loader/FormState.cpp:58
> > +    for (size_t i = 0; i < m_form->associatedElements().size(); ++i) {
> 
> Is calling associatedElements() expensive?

It depends on size of vector/elements number on page. A lot of WebCore methods obtain this object directly (without assignee to auxiliary variable). Can we leave as it is?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.