[Webkit-unassigned] [Bug 77337] [EFL] Refactor ewk_js files.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 2 04:17:50 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=77337





--- Comment #5 from Raphael Kubo da Costa <kubo at profusion.mobi>  2012-02-02 04:17:50 PST ---
(In reply to comment #4)
> Is it really that bad to rewrite everything?

IMO, yes. Besides the code having no useful documentation, there are a lot of style issues such as the ones you are trying to clean up (plus a lot of useless C-isms and manual memory management), similar functions with different order of parameters and bad architecture in general (external code shouldn't be able to access so many structures and their fields directly, ewk_js_npobject_to_object duplicates the Ewk_JS_Object creation code etc).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list