[Webkit-unassigned] [Bug 77434] Web Inspector: show percent along with absolute counts in heap snapshots

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77434


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124950|review?                     |review-
               Flag|                            |




--- Comment #13 from Pavel Feldman <pfeldman at chromium.org>  2012-02-02 04:12:01 PST ---
(From update of attachment 124950)
View in context: https://bugs.webkit.org/attachment.cgi?id=124950&action=review

> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:297
> +        if (view.showPercents) {

nit: view._showPercentage

> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:796
> +        data["sizeDelta"] = this._signForDelta(this._sizeDelta) + Number.withThousandsSeparator(Math.abs(this._sizeDelta));

Why did this change? You should prefer message format to the concatenation.

> Source/WebCore/inspector/front-end/DetailedHeapshotView.js:203
> +        count: { title: WebInspector.UIString("Objects Count"), width: "90px", sortable: true },

you should add this new string to the English.lproj/localizedStrings.js

> Source/WebCore/inspector/front-end/DetailedHeapshotView.js:299
> +        sizeDelta: { title: "Size Delta", width: "72px", sortable: true }

ditto

> Source/WebCore/inspector/front-end/DetailedHeapshotView.js:1094
> +            this.percentButton.title = WebInspector.UIString("Hide percentages of counts and sizes.");

ditto

> Source/WebCore/inspector/front-end/DetailedHeapshotView.js:1097
> +            this.percentButton.title = WebInspector.UIString("Show percentages of counts and sizes.");

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.