[Webkit-unassigned] [Bug 77533] [Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77533


Nandor Huszka <Huszka.Nandor at stud.u-szeged.hu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124936|0                           |1
        is obsolete|                            |
 Attachment #125095|                            |review?, commit-queue?
               Flag|                            |




--- Comment #7 from Nandor Huszka <Huszka.Nandor at stud.u-szeged.hu>  2012-02-02 01:02:29 PST ---
Created an attachment (id=125095)
 --> (https://bugs.webkit.org/attachment.cgi?id=125095&action=review)
Patch

(In reply to comment #5)
I tried it, but it is impossible to indicate 3 cases with one bool variable.
I mean if we put this into isWK2():

if (checkForArgumentAndRemoveFromARGV("-2")) {
  $isWK2 = 0;
} elsif (checkForArgumentAndRemoveFromARGV("--no-webkit2")){
  $isWK2 = 1;
} else {
  $isWK2 = 0;
}

or other combination of ifs, it would be incorrect, I think.
I tried to write an isNotWK2() function, but if in it we use in it the $isWK2 too, its value depends on whether isWK2() or isNotWK2() function was called sooner. But if we use a new, e.g. $isNotWK2 variable in it, it would be incomprehensible why we use $isWK2 and $isNotWK2 too.

(In reply to comment #4)
Ok, I have done that, but I do not understand why can we pass on all the other unchecked options in BUILD_WEBKIT_ARGS to the buildQMakeProjects.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.