[Webkit-unassigned] [Bug 76261] Select attribute of HTMLContentElement should be able to be changed dynamically.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76261





--- Comment #5 from Shinya Kawanaka <shinyak at chromium.org>  2012-02-01 17:11:02 PST ---
(In reply to comment #2)
> (From update of attachment 124898 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124898&action=review
> 
> > Source/WebCore/html/shadow/HTMLContentElement.cpp:128
> > +            root->shadowHost()->setNeedsStyleRecalc();
> 
> Do we need both? I hope setNeedsShadowTreeStyleRecalc() sufficient.

Done.

> 
> > LayoutTests/fast/dom/shadow/content-element-select-dynamic.html:122
> > +            document.getElementById('expect-container').innerHTML = "<div><span>BEFORE</span><span>LIGHT 2</span><span>AFTER</span></div>";
> 
> How about to reverse the order between above two lines to minimize side-effect of innerHTML setter?

Done.

> 
> > LayoutTests/fast/dom/shadow/content-element-select-dynamic.html:244
> > +
> 
> If we already have similar test, could you consider to share the test framework?

I want to do this in a separate bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.