[Webkit-unassigned] [Bug 77477] [chromium] Process scroll-gesture events from the MT compositor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 1 15:16:54 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=77477


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #8 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-02-01 15:16:54 PST ---
Attachment 125028 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1

Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:47:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:47:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:48:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:53:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:54:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:57:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:58:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:61:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:62:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:63:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:68:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:76:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:77:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:79:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:88:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:89:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:92:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:138:  mock_input_handler is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:140:  mock_client is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:190:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 20 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list