[Webkit-unassigned] [Bug 77575] [Texmap] Use glScissors for clipping in TextureMapperGL when possible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77575





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2012-02-01 14:52:51 PST ---
(From update of attachment 125017)
View in context: https://bugs.webkit.org/attachment.cgi?id=125017&action=review

This looks good, but does the patch need to enable the scissor test for non-Qt ports as well?

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:452
> +    glEnable(GL_SCISSOR_TEST);

Shouldn't this be enabled for non-Qt ports as well?

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:736
> +    GLint viewport[4];
> +    glGetIntegerv(GL_VIEWPORT, viewport);
> +    glScissor(rect.x(), viewport[3] - rect.maxY(), rect.width(), rect.height());

I assume this is for handling flipped-Y situations here? Nice!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.