[Webkit-unassigned] [Bug 77509] Enable IPP for Biquad filter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77509





--- Comment #4 from Raymond Toy <rtoy at chromium.org>  2012-02-01 14:00:18 PST ---
(From update of attachment 124886)
View in context: https://bugs.webkit.org/attachment.cgi?id=124886&action=review

> Source/WebCore/platform/audio/Biquad.cpp:58
> +    m_dlyLine = 0;

Can we name this m_delayLine?

> Source/WebCore/platform/audio/Biquad.cpp:205
> +#if USE(WEBAUDIO_IPP)

Maybe combine this with #endif above and use

#elif USE(WEBAUDIO_IPP)

> Source/WebCore/platform/audio/Biquad.cpp:241
>  }

Rather than sprinkling this ippBiquadInit in each filter, I would be better to refactor each set<filter> routine to always call setNormalizedCoefficients instead of assigning the coefficients directly.  Then setNormalizedCoefficients can have the ippBiquadInit call in just the one place.

> Source/WebCore/platform/audio/Biquad.cpp:485
> +{

If the code is refactored to use setNormalizedCoefficients everywhere, then this function can probably be removed and placed directly in setNormalizedCoefficients.

> Source/WebCore/platform/audio/Biquad.h:111
> +void ippBiquadInit(const double b0, const double b1, const double b2, const double a0, const double a1, const double a2);

This should be indented.  (But maybe it can be removed completely if setNormalizedCoefficients is used.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.