[Webkit-unassigned] [Bug 76445] [Qt] build-webkit does not detect the number of CPUs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76445


Tor Arne Vestbø <vestbo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124954|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #9 from Tor Arne Vestbø <vestbo at webkit.org>  2012-02-01 09:45:01 PST ---
(From update of attachment 124954)
View in context: https://bugs.webkit.org/attachment.cgi?id=124954&action=review

good stuff, a few comments:

> Tools/Scripts/webkitdirs.pm:2089
> +    if ($makeargs !~ /-j/i && (!defined $ENV{"MAKEFLAGS"} || ($ENV{"MAKEFLAGS"} !~ /-j/i ))){

Slight style (missing space before {), and the regex will trigger on stuff like --just-print as well. build-webkit uses -j\s*\d+

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.