[Webkit-unassigned] [Bug 77067] Parenthesis in RTL fonts are not mirrored with SVG fonts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77067


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124563|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #22 from Nikolas Zimmermann <zimmermann at kde.org>  2012-02-01 08:23:41 PST ---
(From update of attachment 124563)
View in context: https://bugs.webkit.org/attachment.cgi?id=124563&action=review

Patch looks great, r=me with a few comments:

> Source/WebCore/svg/SVGFontData.cpp:277
> +    for (unsigned i = 0; i < length; ) {

I would have used a while loop for this. No blocker.

> LayoutTests/ChangeLog:11
> +        which handles mirroring the characters when rendering selecting glyphs
> +        for SVG fonts. I also made a small cosmetic change in the function

s/rendering// ? I'm not sure what you mean otherwise.
The ChangeLog should be fixed at least before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.