[Webkit-unassigned] [Bug 77533] [Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77533


Tor Arne Vestbø <vestbo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124936|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Tor Arne Vestbø <vestbo at webkit.org>  2012-02-01 06:14:41 PST ---
(From update of attachment 124936)
View in context: https://bugs.webkit.org/attachment.cgi?id=124936&action=review

> Tools/Scripts/build-jsc:79
> +    if ($ENV{'BUILD_WEBKIT_ARGS'}) {

How about an unconditional

push @ARGV, split(/ /, $ENV{'BUILD_WEBKIT_ARGS'}) if ($ENV{'BUILD_WEBKIT_ARGS'});

> Tools/Scripts/build-jsc:85
> +        push @buildWebKitArgs, split(/ /, $ENV{'BUILD_WEBKIT_ARGS'});
> +        foreach (@buildWebKitArgs) {
> +            if ($_ eq '--no-webkit2') {
> +                push @ARGV, "--qmakearg=CONFIG+=no_webkit2";
> +            }

And then a

push @ARGV, "--qmakearg=CONFIG+=no_webkit2" if checkForArgumentAndRemoveFromARGV("--no-webkit2");

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.