[Webkit-unassigned] [Bug 76720] [chromium] Refactor video drawing to be more data driven

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76720





--- Comment #23 from Tim Dresser <tdresser at chromium.org>  2012-02-01 05:36:03 PST ---
(In reply to comment #22)
> (From update of attachment 124742 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124742&action=review
> 
> Thanks for all of this.  Since you added willDraw in both this patch and the plugin patch, I think you'll have to let one of them land first and then rebase the other on top of ToT.
> 
> jamesr, what do you think?
> 
> > Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:739
> > +void LayerRendererChromium::drawCommon(const CCVideoDrawQuad* quad, Program* program, float widthScaleFactor, Platform3DObject textureId)
> 
> nit: Can you call this something else, like drawSingleTextureVideoQuad? drawCommon is a lot less meaningful of a name when moved to LRC.
> 
> (I also feel like this is yet another set of Programs that could be merged together, but I suppose those can all be done in another changelist.)

Yeah, I've been expecting to land the plugin patch first, and then resubmit the video patch. 

I'll submit 4 new bugs when this and the plugin patch have landed.

1. Merge PluginProgramBindings.
2. Merge Programs for Video.
3. Double Buffer Plugin Layer.
4. Remove the draw call from CCLayerImpl.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.