[Webkit-unassigned] [Bug 77434] Web Inspector: show percent along with absolute counts in heap snapshots

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77434





--- Comment #9 from Ilya Tikhonovsky <loislo at chromium.org>  2012-02-01 04:33:23 PST ---
(From update of attachment 124884)
View in context: https://bugs.webkit.org/attachment.cgi?id=124884&action=review

Looks good to me with nits.

> Source/WebCore/inspector/front-end/DetailedHeapshotView.js:942
> +        return this.showShallowSizeAsPercent && this.showRetainedSizeAsPercent;

Is it possible to have a single flag for percent?

> LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-all.html:42
> +                countA = parseInt(row.data["addedCount"]);

I'd rather fix the expectations.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.