[Webkit-unassigned] [Bug 77179] getIntersectionList causes transforms to be recalculated in SVG

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77179





--- Comment #7 from Peter Beverloo <peter at chromium.org>  2012-02-01 04:02:25 PST ---
(In reply to comment #6)
> (In reply to comment #4)
> > Created an attachment (id=124746)
 --> (https://bugs.webkit.org/attachment.cgi?id=124746&action=review) [details] [details]
> > Patch (+ test)
> > 
> > Added a test following a discussion with pdr in #ksvg.
> 
> I think this change looks good overall.
> 
> A couple very minor nits: I think git is messing up the png in your ChangeLog, which is causing the style guide to complain.
> A common pattern in pixel tests is to have an untranslated green square as "pass". Could you make the initial rotation be 0 or add a comment in the test describing that a rotated green square should be considered passing? This will make it easier for sheriffs/rebaseliners. One way would be to rotate the entire svg element by -50deg.

Thank you. The style-bot was having troubles yesterday so I'm fairly sure it's unrelated to the patch. The new patch should be fine.

I've made the test clearer by making the square blue instead of green, and added a comment that a non-rotated square in the top-left corner is the expected result, whereas other positions and/or rotations are failures.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.