[Webkit-unassigned] [Bug 74386] Migrate createObjectURL & revokeObjectURL to static (Class) methods
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 1 02:43:57 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=74386
--- Comment #40 from David Levin <levin at chromium.org> 2012-02-01 02:43:56 PST ---
(From update of attachment 124918)
View in context: https://bugs.webkit.org/attachment.cgi?id=124918&action=review
This appears to be on the right track now and should work with web workers.
> Source/WebCore/dom/ScriptExecutionContext.cpp:130
> + if (m_publicURLManager)
#if ENABLE(BLOB)
> Source/WebCore/dom/ScriptExecutionContext.cpp:395
> + m_publicURLManager = adoptPtr(new PublicURLManager(this));
Should be PublicURLManager::create (which is a static method that does "return adoptPtr(new PublicURLManager(context));"
> Source/WebCore/html/DOMURL.cpp:3
> + * Copyright (C) 2011 Motorola Mobility Inc.
2012
> Source/WebCore/html/DOMURL.cpp:-28
> -#if ENABLE(BLOB)
Why not leave this if as is?
> Source/WebCore/html/DOMURL.h:59
> +class PublicURLManager : public RefCounted<PublicURLManager> {
I would create a separate header file for this.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list