[Webkit-unassigned] [Bug 77520] [WK2] Modify parameters of willSubmitForm callback

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77520


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124902|review?                     |review-
               Flag|                            |




--- Comment #3 from Adam Barth <abarth at webkit.org>  2012-02-01 02:14:42 PST ---
(From update of attachment 124902)
View in context: https://bugs.webkit.org/attachment.cgi?id=124902&action=review

This patch doesn't have any tests.

> Source/WebCore/loader/FormState.cpp:40
> +static String currentValueKey = "currentValue";

This creates a static initializer and will break the AppleMac build.

> Source/WebCore/loader/FormState.cpp:55
> +const Vector<HashMap<String, String> > FormState::textFieldsPropertis() const

Why are you returning const here?  textFieldsPropertis is misspelled.

> Source/WebCore/loader/FormState.cpp:58
> +    for (size_t i = 0; i < m_form->associatedElements().size(); ++i) {

Is calling associatedElements() expensive?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.