[Webkit-unassigned] [Bug 76378] [EFL] Modify the code to webkit-style and adapt to C++ naming.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 1 00:21:41 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=76378





--- Comment #34 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-02-01 00:21:41 PST ---
(From update of attachment 124866)
View in context: https://bugs.webkit.org/attachment.cgi?id=124866&action=review

> Source/WebKit/efl/ewk/ewk_tiled_matrix.h:29
> +Ewk_Tile_Matrix *ewk_tile_matrix_new(Ewk_Tile_Unused_Cache *tileUnusedCache, unsigned long columns, unsigned long rows, float zoomLevel, Evas_Colorspace colorSpace, void (*render_callback)(void *data, Ewk_Tile *tile, const Eina_Rectangle *update), const void *renderData);

Is it possibility to open ewk_tiled_xxx header files for application ? If they never be opened to outer, we don't need to use abbreviation in ewk_tiled_xxx files. But, if there is a few possibility, I think we need to keep this style.

> Source/WebKit/efl/ewk/ewk_tiled_matrix.h:34
> +void ewk_tile_matrix_invalidate(Ewk_Tile_Matrix *tileMatrix);

Hmm, above functions use full name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list