[Webkit-unassigned] [Bug 100225] [EFL][WK2] Add APIs to get/set the default text encoding name

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100225





--- Comment #8 from Yuni Jeong <yhnet.jung at samsung.com>  2012-12-30 22:17:34 PST ---
(From update of attachment 170356)
View in context: https://bugs.webkit.org/attachment.cgi?id=170356&action=review

>> Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:265
>> +
> 
> EINA_SAFETY_ON_NULL_RETURN_VAL(encoding, false);?

I added EINA_SAFETY_ON_NULL_RETURN_VAL(encoding, false).

>> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:320
>> +EAPI const char* ewk_settings_default_encoding_get(const Ewk_Settings *settings);
> 
> Nit : wrong * place.

I changed * place to "const char *ewk_settings_default_encoding_get".

>> Source/WebKit2/UIProcess/API/efl/ewk_settings_private.h:41
>> +    mutable WKEinaSharedString defaultTextEncoding;
> 
> Why do we need to add this variable?

Because memory for returned default encoding name is released after ewk_settings_default_encoding_get() is called,
So, defaultTextEncoding variable is needed to keep returned default encoding name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.