[Webkit-unassigned] [Bug 105292] [GStreamer] GstMessage handler in AudioDestination

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105292





--- Comment #14 from Christophe Dumez <christophe.dumez at intel.com>  2012-12-30 06:31:57 PST ---
(In reply to comment #13)
> (In reply to comment #12)
> > Created an attachment (id=180954)
 --> (https://bugs.webkit.org/attachment.cgi?id=180954&action=review) [details] [details]
> > Test patch using manual unref'ing
> > 
> > FYI, switching to raw pointers and using gst_object_unref (see attached patch) fixes the crashes for me (I don't see any warnings on stderr either). I'm not quite sure why this is different from using a smart pointer and adopting though.
> 
> Because adoptGref() checks if the object has a floating ref or not.
> So yeah either we use raw pointers or revert the parts of the landed patch that added the adoptGRef calls.
> 
> I'd be for using raw pointers, I never really liked this smart pointer stuff :P

Ok, I uploaded a patch at Bug 105869. I also prefer using raw pointers in this case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.