[Webkit-unassigned] [Bug 105783] Remove extra space in CustomFilterRenderer.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 28 08:32:17 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=105783





--- Comment #7 from Sam Weinig <sam at webkit.org>  2012-12-28 08:34:23 PST ---
(In reply to comment #6)
> (In reply to comment #2)
> > This seems like an unnecessary change.  This can be fixed the next time that line is touched.
> 
> Sam: As you mentioned, conventionally WebKit doesn't accept style-only-fix patches (in order not to mess up histories). But do we have any coding guideline about that? (When I was asked about that last time, I couldn't find the policy anywhere.)

I don't think there is a policy (and I am not sure how much weight I give the messing up histories argument, you can always go back further), nor do I think we really need or want one.  We actually have a history of doing style clean up to make sure things stay spiffy.  In this case, my gripe was with how marginal the change was.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list