[Webkit-unassigned] [Bug 105252] REGRESSION: Review tool sometimes doesn't include some comments in preview & posts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105252


Alexander Pavlov (apavlov) <apavlov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |apavlov at chromium.org




--- Comment #7 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2012-12-27 07:40:24 PST ---
(In reply to comment #6)
> I reproduced this bug on https://bugs.webkit.org/attachment.cgi?id=180637&action=review once when I was commenting on DeleteSelectionCommand.cpp change at lines 483-484.
> 
> Here's my analysis. The problem is that forEachLine prematurely stops iteration at #line32 when it's called by fillInReviewForm because #line33 doesn't exist on this page (it appears that this doesn't reproduce reliably either).

Another manifestation, same cause: I expanded the diff (20 above, 20 below...), which inserted a number of ".ExpansionLine"s, but removed ".Line.LineContainer.context" having a line number! Thus, a hole in the line number sequence appeared, and that was the reason for forEachLine premature bail-out. Thus, all comments after the first expanded source chunk were lost.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.