[Webkit-unassigned] [Bug 105618] [EFL][WK2] Fix the position of cursor when handling preedit string

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105618





--- Comment #15 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-12-25 22:46:54 PST ---
(From update of attachment 180707)
View in context: https://bugs.webkit.org/attachment.cgi?id=180707&action=review

>>>> Source/WebKit2/UIProcess/efl/InputMethodContextEfl.cpp:74
>>>> +    int cursorPosition = preeditString.length() + preeditPosition;
>>> 
>>> Why preeditString.length() + preeditPosition ? I thought preeditPosition was already the cursor position within the preedit string?
>> 
>> It could be 0. (in case of korean)
> 
> It is an offset into preedit string.
> We need cursor position for the argument of setCompositon. (not cursor position within preedit string)

By the way, I wonder if cursorPosition can support meaningful functionality. Because, EFL port doesn't support *selectionEnd* parameter though cursorPosition means *selectionStart* in Editor.h.

In WebPageEfl.cpp, it sets last parameter with 0.

void WebPage::setComposition(const String& compositionString, const Vector<WebCore::CompositionUnderline>& underlines, uint64_t cursorPosition)
{
...
    targetFrame->editor()->setComposition(compositionString, underlines, cursorPosition, 0);


Shouldn't we support *selectionEnd* parameter as Qt and Mac ports ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.