[Webkit-unassigned] [Bug 105252] REGRESSION: Review tool sometimes doesn't include some comments in preview & posts

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 23 22:28:55 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=105252





--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2012-12-23 22:31:06 PST ---
I reproduced this bug on https://bugs.webkit.org/attachment.cgi?id=180637&action=review once when I was commenting on DeleteSelectionCommand.cpp change at lines 483-484.

Here's my analysis. The problem is that forEachLine prematurely stops iteration at #line32 when it's called by fillInReviewForm because #line33 doesn't exist on this page (it appears that this doesn't reproduce reliably either).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list