[Webkit-unassigned] [Bug 105548] [CSS Grid Layout] Add the plumbing to parse -webkit-grid-{column, row}-span

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105548


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #180500|                            |review?
               Flag|                            |




--- Comment #1 from Xan Lopez <xan.lopez at gmail.com>  2012-12-21 04:52:15 PST ---
Created an attachment (id=180500)
 --> (https://bugs.webkit.org/attachment.cgi?id=180500&action=review)
column-row-span.diff

As done in previous features, this only adds the parsing bits, no effects on layout yet.

The two things I consider are probably up for debate:

- I use GridPosition to store the span, it might be better to create a new type (GridSpan?)
- I actually store the span in the item data. Perhaps it would be better to store a second GridPosition (m_gridColumnEnd, m_gridRowEnd?), and figure out the span doing end-start.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.