[Webkit-unassigned] [Bug 104600] [Chromium] Always enable autocomplete for password fields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104600





--- Comment #26 from Yue Zhang <zysxqn at chromium.org>  2012-12-20 16:57:53 PST ---
(In reply to comment #25)
> (From update of attachment 180437 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180437&action=review
> 
> > Source/WebCore/page/Settings.cpp:422
> > +void Settings::setIgnoreWebkitAutocompleteOff(bool ignoreWebkitAutocompleteOff)
> 
> Why is the substring "Webkit" in this method name?

Because we don't completely ignore autocomplete=off, just don't check/handle this in webkit (will handle this in chrome code). So we choose the name like this.
> 
> > Source/WebKit/chromium/src/WebPasswordFormUtils.cpp:88
> > +                || inputElement->shouldAutocomplete())) {
> 
> Perhaps the implementation of shouldAutocomplete should inspect the ignoreAutocompleteOff setting?
> That way, every caller of shouldAutocomplete will see the same value, and we will not have to
> repeat the settings test at each callsite of shouldAutocomplete.

The whole point of not checking autocomplete in webkit is that we don't have enough information in webkit code (we ignore autocomplete setting for chrome generated passwords, but respect it for other normal passwords). So for the same reason, I don't see how we can handle autocomplete setting in the implementation of shouldAutocomplete? maybe I miss anything?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.