[Webkit-unassigned] [Bug 104600] [Chromium] Always enable autocomplete for password fields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104600





--- Comment #25 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2012-12-20 16:53:03 PST ---
(From update of attachment 180437)
View in context: https://bugs.webkit.org/attachment.cgi?id=180437&action=review

> Source/WebCore/page/Settings.cpp:422
> +void Settings::setIgnoreWebkitAutocompleteOff(bool ignoreWebkitAutocompleteOff)

Why is the substring "Webkit" in this method name?

> Source/WebKit/chromium/src/WebPasswordFormUtils.cpp:88
> +                || inputElement->shouldAutocomplete())) {

Perhaps the implementation of shouldAutocomplete should inspect the ignoreAutocompleteOff setting?
That way, every caller of shouldAutocomplete will see the same value, and we will not have to
repeat the settings test at each callsite of shouldAutocomplete.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.