[Webkit-unassigned] [Bug 105486] Need to re-layout fixed position elements after scale when using settings()->fixedElementsLayoutRelativeToFrame()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105486





--- Comment #7 from Tien-Ren Chen <trchen at chromium.org>  2012-12-20 14:37:34 PST ---
(In reply to comment #6)
> (From update of attachment 180405 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180405&action=review
> 
> > Source/WebCore/rendering/RenderView.cpp:1045
> > +    TrackedRendererListHashSet* positionedDescendants = positionedObjects();
> > +    if (!positionedDescendants)
> > +        return;
> > +    TrackedRendererListHashSet::iterator end = positionedDescendants->end();
> > +    for (TrackedRendererListHashSet::iterator it = positionedDescendants->begin(); it != end; ++it) {
> > +        RenderBox* renderer = *it;
> > +        if (renderer->style()->position() != FixedPosition)
> > +            continue;
> > +        renderer->setNeedsPositionedMovementLayout();
> 
> You should use FrameView's list of fixed objects, not this one.

Ah, that's a really good suggestion! I'll change it.

By the way, I'm thinking to remove the USE(ACCELERATED_COMPOSITING) guard on Frame::deviceOrPageScaleFactorChanged() so the re-layout will be triggered from there instead of Page. Do you think that sounds like a better plan?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.