[Webkit-unassigned] [Bug 77864] [Qt] Initial implementation of accessibility support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77864


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #180345|review?                     |review-
               Flag|                            |




--- Comment #29 from Simon Hausmann <hausmann at webkit.org>  2012-12-20 13:47:18 PST ---
(From update of attachment 180345)
View in context: https://bugs.webkit.org/attachment.cgi?id=180345&action=review

> Source/WTF/WTF.pri:42
> +haveQt(5): contains(QT_CONFIG,accessibility): DEFINES += HAVE_ACCESSIBILITY=1

This should probably go into features.pri.

> Source/WebCore/accessibility/qt/AccessibilityObjectQt.cpp:40
> +void AccessibilityObject::setWrapper(AccessibilityObjectWrapper *wrapper)

* placement

> Source/WebCore/accessibility/qt/AccessibilityObjectWrapperQt.cpp:126
> +                    QScopedPointer<QAccessibleInterface> webView(QAccessible::queryAccessibleInterface(pageClient->ownerWidget()));

How do the other ports handle this? Is there a simpler or common way?

> Source/WebCore/accessibility/qt/AccessibilityObjectWrapperQt.h:28
> +class QWebFrame;

That doesn't seem to be needed

> Source/WebKit/qt/WidgetApi/qwebviewaccessible.cpp:34
> +    if (!WebCore::AXObjectCache::accessibilityEnabled())

This class (qwebviewaccessible) needs to move from QtWebKitWidgets into QtWebKit. Try compiling with make && make to see when this is needed (instead of build-webkit)

(This is a flaw in our current build process)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.