[Webkit-unassigned] [Bug 105324] Use ElementTraversal in LiveNodeListBase

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105324





--- Comment #12 from Antti Koivisto <koivisto at iki.fi>  2012-12-19 14:52:20 PST ---
(In reply to comment #10)
> Do we need "this->"?

Yeah, the local variable hides the function.

> Can we change this to type() == ChildNodeList? If not, I'll do that.

Done. 

> Can we assert that ASSERT(currentOffset < offset); at the beginning?

Did these.

> > +    ASSERT(!overridesItemAfter());
> 
> I don't think this assertion is useful given that we're already asserting type() is ChildNodeListType since only HTMLCollection overrides itemAfter.

Removed.

> We can add UNLIKELY here as well although I don't think it'll matter.

Removed the remaining UNLIKELY. Since the branches are now outside of loops, they are unlikely to make a difference.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.