[Webkit-unassigned] [Bug 105189] Add function to move caret selection towards a point

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 19 14:20:55 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=105189





--- Comment #19 from Ryosuke Niwa <rniwa at webkit.org>  2012-12-19 14:23:09 PST ---
(In reply to comment #18)
>
> I suspect this is the core confusion.  For other ports, WebKit itself draws all the input UI, like the cursor, etc.  In this case, Chromium is drawing it's own selection UI (in addition to WebKits) and thus needs a hook to tell WebKit to update it's part of things.   As Ryosuke points out, if this were in WebKit, most of the code would just be in EventHandler.cpp (the drawing code likely in RenderThemeChromiumAndroid?).

It’s drawn by WebCore even. See CaretBase::paintCaret in FrameSelection.cpp.

> I'm not sure this patch is wrong.  Just slightly atypical for WebKit's previous editing design.

I concur. This "feels wrong".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list