[Webkit-unassigned] [Bug 104835] Web Inspector: Don't throw exceptions in WebInspector.Color

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104835





--- Comment #7 from Yury Semikhatsky <yurys at chromium.org>  2012-12-19 03:26:55 PST ---
(From update of attachment 179780)
View in context: https://bugs.webkit.org/attachment.cgi?id=179780&action=review

>>> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1744
>>> +                if (text !== 'none') {
>> 
>> No need to check explicitly for 'none' as Color.parse would return null for it.
> 
> Yes, however, unlike an erroneous user input, 'none' is a correct user input which is not a color. For the best user experience we should be giving correct feedback. To start on that path we should avoid sending Color.parse() values we know are not colors. However I cannot go further at this time because I don't know the complete list of correct user inputs that are not colors.
> 
> How about if I change it to a comment?

A comment would probably be more clear at this point.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.