[Webkit-unassigned] [Bug 105253] 2 clampTo unit tests are failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105253





--- Comment #3 from Julien Chaffraix (vacations 20 dec -> 5 jan) <jchaffraix at webkit.org>  2012-12-18 17:11:24 PST ---
(In reply to comment #2)
> The windows unsigned failure is due to sizeof(unsigned long) == sizeof(unsigned) on windows 64bit (as it used the LLP64 memory model).
> 
> Adding a sizeof check as you have for clampToIntLong should do the trick.

True, but clampToUnsigned is testing the same case as clampToUnsignedLong as we can't test overflowing without a type that is wider than unsigned. This makes me lean towards just removing this test (FWIW we don't have a clampToInt for this very reason).

> The chromium mac failure seems to be due to float imprecision, EXPECT_NEAR with a tolerance of 1 should do the trick.

Good catch, that should fix the issue.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.