[Webkit-unassigned] [Bug 104600] [Chromium] Always enable autocomplete for password fields

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 18 15:02:08 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=104600





--- Comment #16 from Yue Zhang <zysxqn at chromium.org>  2012-12-18 15:04:23 PST ---
(In reply to comment #15)
> (In reply to comment #14)
> > (In reply to comment #12)
> > > Isn't that a chrome/ feature (as opposed to content/)? Shouldn't we in that case make this somehow configurable?
> > > 
> > > Also, what about tests?
> > 
> > Yeah it's a chrome feature. 
> 
> Ok, then it should be configurable - otherwise other content embedders might end up just ignoring this field

  I see WebPasswordFormUtils.cpp is under chromium/ directory so I thought it's only used by chromium code. No? If not, how to make it configurable? command line flags? I'm really new to WebKit so any more detailed suggestion is welcomed :)
> 
> > 
> > Regarding test, I'm not super familiar with Webiit code. I think this is a pretty trivial change. Shall we reflect it somewhere in the Webkit unittest?
> 
> sounds good. there are unit tests in http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/tests/

Looks that there is no existing tests regarding WebPasswordFormUtils class. Is it really worth a new test file given that it is a trivial two-line change?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list