[Webkit-unassigned] [Bug 104760] [EFL] Allow the build system to find OpenGL ES

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104760





--- Comment #5 from Laszlo Gombos <laszlo.gombos at webkit.org>  2012-12-18 14:25:59 PST ---
(In reply to comment #4)
> (From update of attachment 180005 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180005&action=review
> 

> > Source/cmake/FindGLES.cmake:40
> > +mark_as_advanced(OPENGLES2_INCLUDE_DIR OPENGLES2_gl_LIBRARY)
> 
> Perhaps we can move this to the FIND_PACKAGE_HANDLE_STANDARD_ARGS macro (and remove it from the other FindXXX.cmake files that are already using FIND_PACKAGE_HANDLE_STANDARD_ARGS macro (e.g. FindFontconfig.cmake). This is unrelated so best to do it in a new bug.

I just noticed that FIND_PACKAGE_HANDLE_STANDARD_ARGS is a macro that comes with cmake - in that case this part of the patch is correct.

I filed bug 105350 to follow this practice consistently.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.