[Webkit-unassigned] [Bug 104760] [EFL] Allow the build system to find OpenGL ES

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104760





--- Comment #4 from Laszlo Gombos <laszlo.gombos at webkit.org>  2012-12-18 13:55:15 PST ---
(From update of attachment 180005)
View in context: https://bugs.webkit.org/attachment.cgi?id=180005&action=review

> Source/cmake/FindGLES.cmake:8
> +# Copyright (C) 2012 Intel Corporation. All rights reserved.

It seems that you have not used much really from https://bitbucket.org/sinbad/ogre/src/3cbd67467fab3fef44d1b32bc42ccf4fb1ccfdd0/CMake/Packages/FindOpenGLES2.cmake?at=default, so I think this Copyright is ok.

> Source/cmake/FindGLES.cmake:38
> +if (OPENGLES2_gl_LIBRARY)
> +    set(OPENGLES2_LIBRARIES ${OPENGLES2_gl_LIBRARY} ${OPENGLES2_LIBRARIES})
> +    set(OPENGLES2_FOUND "YES")
> +endif (OPENGLES2_gl_LIBRARY and EGL_egl_LIBRARY)

I think we should use the FIND_PACKAGE_HANDLE_STANDARD_ARGS macro instead to align with other FindXX.cmake files.

> Source/cmake/FindGLES.cmake:40
> +mark_as_advanced(OPENGLES2_INCLUDE_DIR OPENGLES2_gl_LIBRARY)

Perhaps we can move this to the FIND_PACKAGE_HANDLE_STANDARD_ARGS macro (and remove it from the other FindXXX.cmake files that are already using FIND_PACKAGE_HANDLE_STANDARD_ARGS macro (e.g. FindFontconfig.cmake). This is unrelated so best to do it in a new bug.

> ChangeLog:11
> +        FindGLES.cmake is loosely based on the example from
> +        https://bitbucket.org/sinbad/ogre/src/3cbd67467fab3fef44d1b32bc42ccf4fb1ccfdd0/CMake/Packages/FindOpenGLES2.cmake?at=default.

I do not think we need to mention this here. The bug has a reference to this if someone wants to extend this simple version in this patch and support more platforms.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.