[Webkit-unassigned] [Bug 104366] Make order iterator member stack allocated in RenderFlexibleBox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104366


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #179926|review?                     |review-
               Flag|                            |




--- Comment #13 from Tony Chang <tony at chromium.org>  2012-12-18 11:09:38 PST ---
(From update of attachment 179926)
View in context: https://bugs.webkit.org/attachment.cgi?id=179926&action=review

> Source/WebCore/ChangeLog:8
> +        It avoids heap allocations during the layout.

Nit: I would say, "It avoids a heap allocation during layout."

> Source/WebCore/rendering/RenderFlexibleBox.h:92
> +        void setOrderValues(const OrderHashSet& orderValues)
> +        {
> +            reset();

Can we move this method definition into the .cpp file? That would also let you keep OrderHashTraits in the .cpp file.

> Source/WebCore/rendering/RenderFlexibleBox.h:107
> +        RenderBox* next()
> +        {
> +            do {

Can we move this method definition into the .cpp file?

> Source/WebCore/rendering/RenderFlexibleBox.h:133
> +    private:
> +        RenderFlexibleBox* m_flexibleBox;

Maybe add WTF_MAKE_NONCOPYABLE(OrderIterator) to avoid accidental copies?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.