[Webkit-unassigned] [Bug 105085] [JSC] Use WorkerScriptDebugServer::debuggerTaskMode instead of WorkerDebuggerAgent::debuggerTaskMode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 17 21:13:51 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=105085





--- Comment #3 from Yury Semikhatsky <yurys at chromium.org>  2012-12-17 21:16:08 PST ---
(From update of attachment 179582)
View in context: https://bugs.webkit.org/attachment.cgi?id=179582&action=review

> Source/WebCore/bindings/js/WorkerScriptDebugServer.cpp:96
> +        result = m_workerContext->thread()->runLoop().runInMode(m_workerContext, WorkerScriptDebugServer::debuggerTaskMode);

We should leave only one of WorkerDebuggerAgent::debuggerTaskMode and WorkerScriptDebugServer::debuggerTaskMode and remove other one. It'd prefer leaving  WorkerDebuggerAgent::debuggerTaskMode but WorkerScriptDebugServer should not depend on WorkerDebuggerAgent as dependency is in the opposite direction. To overcome this we way pass debuggerTaskMode as a parameter in WorkerScriptDebugServer constructor.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list