[Webkit-unassigned] [Bug 105097] SVG images are sized incorrectly on first load

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105097





--- Comment #6 from Philip Rogers <pdr at google.com>  2012-12-17 20:19:48 PST ---
Thanks for the reviews Dino and Eric!

(In reply to comment #3)
> (From update of attachment 179602 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179602&action=review
> 
> > Source/WebCore/loader/cache/CachedImage.cpp:335
> > +        for (ContainerSizeRequests::iterator it = m_pendingContainerSizeRequests.begin(); it != m_pendingContainerSizeRequests.end(); ++it)
> > +            setContainerSizeForRenderer(it->key, it->value.first, it->value.second);
> 
> We should clear pending requests after we send them.
Done.

> 
> > Source/WebCore/loader/cache/CachedImage.h:64
> > -    void setContainerSizeForRenderer(const RenderObject*, const IntSize&, float);
> > +    void setContainerSizeForRenderer(const CachedImageClient*, const IntSize&, float);
> 
> We should just remove "renderer" from this.  It's somewhat of a layering violation IMO for the loader to know anything about the rendering tree.  This can be in a follow-up patch if you'd rather.

I agree; lets do it as a followup though. I filed WK105244 to track this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.