[Webkit-unassigned] [Bug 99588] Use forwarder2 in Chrome for Android layout tests.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99588





--- Comment #41 from Eric Seidel <eric at webkit.org>  2012-12-17 10:32:25 PST ---
(From update of attachment 179740)
View in context: https://bugs.webkit.org/attachment.cgi?id=179740&action=review

Have to run, more comments soon.

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:498
> +    def setup_md5sum(self):
> +        self._md5sum_path = self._path_builder(MD5SUM_DEVICE_FILE_NAME)
> +        if not self.file_exists_on_device(MD5SUM_DEVICE_PATH):
> +            if not self.push_to_device(self._md5sum_path, MD5SUM_DEVICE_PATH):
> +                raise AssertionError('Could not push md5sum to the device')

Seems these paths should be members of this class, if this information is going to be used here?  Or passed in from teh chromium port?  I had trouble with this layering in my attempt at this too.

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:501
> +    def get_adb_command(self):
> +        return self._adb_command

WebKit style doesn't normally use get_ for getters.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.