[Webkit-unassigned] [Bug 105180] [GTK] When the WebProcess crashes, a signal should be emitted

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105180





--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2012-12-17 08:38:54 PST ---
(From update of attachment 179743)
View in context: https://bugs.webkit.org/attachment.cgi?id=179743&action=review

Looks good, expect I'm not totally certain you are handling use via the C API.

> Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:122
> -    notImplemented();
> +    webkitWebViewWebProcessCrashed(WEBKIT_WEB_VIEW(m_viewWidget));

Is it safe to assume that m_viewWidget is a WebKitWebView here? For instance, when using the C API it could be a WebKitWebViewBase.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1281
> +     * This signal is emitted when the web process crashed.

Probably want to expand this a bit. Explain when the web process will start again (on a new load, typically).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.