[Webkit-unassigned] [Bug 105087] Some Math.pow test262 tests fail with MinGW-w64

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 17 01:40:34 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=105087





--- Comment #6 from Simon Hausmann <hausmann at webkit.org>  2012-12-17 01:42:52 PST ---
(From update of attachment 179593)
View in context: https://bugs.webkit.org/attachment.cgi?id=179593&action=review

> Source/JavaScriptCore/runtime/MathObject.cpp:235
> +#ifdef __MINGW64_VERSION_MAJOR

I think this should be #if COMPILER(MINGW64)

> Source/JavaScriptCore/runtime/MathObject.cpp:244
> +    if ((x == 0.0 || isinf(x)) && isfinite(y)) {
> +        double f;
> +        if (modf(y, &f) != 0.0)
> +            return ((x == 0.0) ^ (y > 0.0)) ? std::numeric_limits<double>::infinity() : 0.0;
> +    }
> +
> +    if (x == 2.0) {

Isn't it dangerous to compare doubles to constants like that? Shouldn't it be done as a range comparison using a epsilon?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list