[Webkit-unassigned] [Bug 103898] [GStreamer] create playbin in ::load(), not in player constructor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 15 11:28:33 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=103898





--- Comment #10 from Philippe Normand <pnormand at igalia.com>  2012-12-15 11:30:52 PST ---
(From update of attachment 179601)
View in context: https://bugs.webkit.org/attachment.cgi?id=179601&action=review

Some more feedback, I'd still like to test this patch as well :)

> Source/WebCore/ChangeLog:8
> +        This patch does the instantiation of the playbin pipeline into the  WebCore::MediaPlayerPrivateGStreamer::load() method, so we could construct the pipeline take in count other possible options, such as pitch.

Sorry for the late feedback on this, can you please wrap this line so it's not ultra wide huge? :)

Also rephrase the second part, such as "so the pipeline layout can reflect other predefined settings such as audio pitch preservation in variable playback rate scenarios" ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list