[Webkit-unassigned] [Bug 104436] [Qt] MinGW-w64 64-bit build fails when linking libQt5WebKitWidgetsd

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 15 10:51:54 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=104436





--- Comment #14 from Andras Becsi <abecsi at webkit.org>  2012-12-15 10:54:13 PST ---
(In reply to comment #11)
> (From update of attachment 179585 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179585&action=review
> 
> >> Tools/ChangeLog:3
> >> +        Fix linking of libraries with -Wl,-whole-archive
> > 
> > The ChangeLog should have the same title as the bug.
> 
> I disagree. Is that rule documented somewhere? I find it very unintuitive that the one-line-summaries of patches describe the original bug, not a summary of the fix.

Indeed it is not documented, but it is applied as a de-facto rule, since the short description of the changelog is not the same as the one-line-summary in git terminology.

I think the title in the changelog should give the context for the patch, which also includes the port and configuration affected, which is in most cases the same as bug title,  but this does not mean that the further description of the patch should be the same as the bug report.

Anyway, this is subjective and does not affect the relevance of the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list