[Webkit-unassigned] [Bug 104970] Web Inspector: Search by selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104970





--- Comment #5 from johnjbarton <johnjbarton at chromium.org>  2012-12-14 08:48:19 PST ---
(In reply to comment #3)
> (From update of attachment 179365 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=179365&action=review
> 
> Looks good, style nits inline.
> 
> > Source/WebCore/inspector/front-end/AdvancedSearchController.js:246
> > +    syncToSelection: function()
> 
> Rename to _syncToSelection (make private)

Just so I understand:  private-per-file not per-class ? The function is call is across classes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.