[Webkit-unassigned] [Bug 104662] [EFL][GTK][Mac][Chromium] Share accessibility LayoutTest

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 14 08:43:19 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=104662





--- Comment #5 from Joanmarie Diggs (irc: joanie) <jdiggs at igalia.com>  2012-12-14 08:45:39 PST ---
(In reply to comment #4)
> > It will need to be conditionalized (toolkit:WebKitGtk and toolkit:WebKitEfl are AtkObject attributes)
> Yes, It can be changed in WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
> attributeSet = addToAtkAttributeSet(attributeSet, "toolkit", "WebKitGtk");

The code currently distinguishes between WebKitGtk versus WebKitEfl. Unless we know for a fact that this distinction will never become relevant, we can conditionalize the test (i.e. via testRunner.platformName) rather than change the code and report a different toolkit to ATs. Especially given the fact that the Layout tests don't check the AtkObject attributes all that often.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list